Skip to content

Conversation

@SamuZad
Copy link
Contributor

@SamuZad SamuZad commented Jan 23, 2025

Fixes #368 - deletion_protection being introduced to google_workflows_workflow

@SamuZad SamuZad requested review from a team and davenportjw as code owners January 23, 2025 22:26
@apeabody apeabody changed the title add deletion protection variable to google_workflows_workflow fix: add deletion protection variable to google_workflows_workflow Jan 23, 2025
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @SamuZad!

Can you please bump the Google and Google Beta providers to ">= 6.11, < 7" in https://github.com/terraform-google-modules/terraform-google-bigquery/blob/main/modules/data_warehouse/versions.tf

@apeabody apeabody changed the title fix: add deletion protection variable to google_workflows_workflow fix(TPG>=6.11)!: add deletion protection variable to google_workflows_workflow Jan 23, 2025
@apeabody
Copy link
Contributor

Marked as breaking change due to TPG bump

@apeabody
Copy link
Contributor

/gcbrun

@SamuZad
Copy link
Contributor Author

SamuZad commented Jan 23, 2025

Done!

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @SamuZad!

@apeabody apeabody merged commit 7233527 into terraform-google-modules:main Jan 23, 2025
4 checks passed
@SamuZad SamuZad deleted the feature/workflow-deletion-protection branch January 23, 2025 23:24
@SamuZad
Copy link
Contributor Author

SamuZad commented Jan 23, 2025

Thanks for the swift response! I really appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to fix CI / TPG v6.11.0+

2 participants